volosied commented on code in PR #349:
URL: https://github.com/apache/myfaces/pull/349#discussion_r997455448
##########
impl/src/main/java/org/apache/myfaces/view/facelets/tag/composite/CompositeResourceLibrary.java:
##########
@@ -49,7 +49,7 @@
*/
public class CompositeResourceLibrary implements TagLibrary
{
- public final static String NAMESPACE_PREFIX = "jakarta.faces.composite";
+ public final static String NAMESPACE_PREFIX = "jakarta.faces.composite/";
// Forward slash added under MYFACES-4484
public final static String JCP_NAMESPACE_PREFIX =
"http://xmlns.jcp.org/jsf/composite/";;
public final static String SUN_NAMESPACE_PREFIX =
"http://java.sun.com/jsf/composite/";;
Review Comment:
CompositeLibrary namespaces do **not** need slashes, but
CompositeResourceLibrary namespaces **do**
https://github.com/apache/myfaces/blob/89c747e85615e3f33265e664c8361789f38ea7db/impl/src/main/java/org/apache/myfaces/view/facelets/tag/composite/CompositeLibrary.java#L29-L31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
