[
https://issues.apache.org/jira/browse/MYFACES-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675582#comment-17675582
]
Thomas Andraschko commented on MYFACES-4525:
--------------------------------------------
[~volosied] what exactly is the purpose of this ticket?
our own FacesServletMapping has some more information, we cant just replace it
> Update Faces to Use Servlet's HttpServletMapping
> ------------------------------------------------
>
> Key: MYFACES-4525
> URL: https://issues.apache.org/jira/browse/MYFACES-4525
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 4.0.0-RC2
> Reporter: Volodymyr Siedlecki
> Priority: Minor
>
> Rather than generating the mappings ourselves, we should just rely on
> HttpServletMapping:
> https://jakarta.ee/specifications/servlet/6.0/apidocs/jakarta.servlet/jakarta/servlet/http/httpservletmapping
> I tried updating it myself, but ran into issues with the unit test since we
> don't have an underlying servlet in these tests (but a Mock one instead).
> This caused the returned HttpServletMapping to be nul due to the super call
> belowl, and hundreds of tests failed.
> https://github.com/apache/myfaces/blob/89c747e85615e3f33265e664c8361789f38ea7db/test/src/main/java/org/apache/myfaces/test/mock/MockHttpServletRequest.java#L1117
>
> {code:java}
> @Override
> public HttpServletMapping getHttpServletMapping()
> {
> return HttpServletRequest.super.getHttpServletMapping();
> }
> {code}
> Initial test branch: https://github.com/volosied/myfaces/commits/fix-mappings
> By updating here, we would also follow Mojarra:
> https://github.com/eclipse-ee4j/mojarra/pull/4956
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
