Hi Paul,

there is no harm to leave it but there is also no benefit AFAICS as
getFeatureDescriptors isnt really used.
It was just a idea to cleanup code.
But we can leave it as it is for now and do it in EE11.

Am Mi., 18. Jan. 2023 um 20:31 Uhr schrieb Paul Nicolucci <
[email protected]>:

> Hi Thomas,
>
> The getFeatureDescriptors method was deprecated in Expression Language 5.0: 
> https://jakarta.ee/specifications/expression-language/5.0/apidocs/jakarta.el/jakarta/el/elresolver#getFeatureDescriptors(jakarta.el.ELContext,java.lang.Object)
>  (EE10).
>
> Why would we remove the code we have for Faces 4.0 (EE10) if it is just 
> deprecated and not totally removed? Is there any harm with keeping it in 
> Faces 4.0 and then removing it in EE11 when Expression Language 6 removes it 
> without replacement?
>
> At least keeping it for Faces 4.0 we wouldn't break anyone who potentially 
> has a dependency on it while it is just deprecated. Perhaps just make these 
> methods deprecated in the MyFaces Impl?
>
> Another question, what Servlet 5 / EE9 stuff was added for Faces 4.0?
>
> Thanks,
>
> Paul Nicolucci
>
>
> On Wed, Jan 18, 2023 at 11:01 AM Melloware <[email protected]> wrote:
>
>> I agree with that Thomas.
>>
>>
>> On 1/18/2023 5:36 AM, Thomas Andraschko wrote:
>> > Hi,
>> >
>> > currently we compile on EE10 but e.g. Jetty isnt ready yet, so i added
>> > support for Servlet5/EE9 on MyFaces 4.0.
>> > What about EL?
>> > In EL EE10 getFeatureDescriptors was deprecated and has a empty
>> > default impl. In EL EE9 getFeatureDescriptors is still there but it
>> > seems that is somehow a not useful method, only used by IDEs? Not sure.
>> >
>> > I would at least modify all getFeatureDescriptors methods to just do
>> > nothing for now.
>> > And later, if we decide to not support Servlet5/EE9 anymore, we can
>> > remove them completely.
>> > WDYT?
>> >
>> > Best regards,
>> > Thomas
>>
>

Reply via email to