[ 
https://issues.apache.org/jira/browse/MYFACES-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684688#comment-17684688
 ] 

Thomas Andraschko commented on MYFACES-4408:
--------------------------------------------

migrated to JUnit5 + enabled paralell tests, which results in ~1min instead of 
~2min build time for myfaces-impl

> Migrate all tests to JUnit5
> ---------------------------
>
>                 Key: MYFACES-4408
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4408
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-372
>    Affects Versions: 2.3-next-M6
>         Environment: junit 4.13.2, myfaces-test 2.3-next-M6
>            Reporter: Stanislav Pacvon
>            Assignee: Thomas Andraschko
>            Priority: Minor
>             Fix For: 4.0.0-RC5
>
>
> JUnit38ClassRunner is used for tests when test classes extends 
> AbstractJsfConfigurableMockTestCase. It is because 
> AbstractJsfConfigurableMockTestCase extends TestCase and there is check in 
> JUnit3Builder 
> {code:java}
> public class JUnit3Builder extends RunnerBuilder {
>     @Override
>     public Runner runnerForClass(Class<?> testClass) throws Throwable {
>         if (isPre4Test(testClass)) {
>             return new JUnit38ClassRunner(testClass);
>         }
>         return null;
>     }    boolean isPre4Test(Class<?> testClass) {
>         return junit.framework.TestCase.class.isAssignableFrom(testClass);
>     }
> }
> {code}
> Is it correct, that jsf tests have to run with Junit 3?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to