tandraschko commented on code in PR #520:
URL: https://github.com/apache/myfaces/pull/520#discussion_r1107279040
##########
impl/src/main/resources/META-INF/WebConfigParamsLogger.vm:
##########
@@ -34,88 +34,88 @@ public class WebConfigParamsLogger
{
private static final Logger log =
Logger.getLogger(WebConfigParamsLogger.class.getName());
+ private static Boolean LOG_WEB_CONTEXT_PARAM = false;
+
public static void logWebContextParams(FacesContext facesContext)
{
MyfacesConfig myfacesConfig =
MyfacesConfig.getCurrentInstance(facesContext.getExternalContext());
- if (!myfacesConfig.isLogWebContextParams())
- {
- //No log if is disabled or is in auto mode and project stage is
UnitTest or SystemTest
- return;
- }
+ LOG_WEB_CONTEXT_PARAM = myfacesConfig.isLogWebContextParams();
-
- if(myfacesConfig.isRiImplAvailable() &&
myfacesConfig.isMyfacesImplAvailable())
+ if(myfacesConfig.isRiImplAvailable() &&
myfacesConfig.isMyfacesImplAvailable() && log.isLoggable(Level.SEVERE))
Review Comment:
severe should never be disabled TBH
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
