Hi, Thanks for working on these so quickly! I've run build twice now, and both runs were successful! Looks to be revolved! :)
Thanks again! On 2023/02/16 11:20:56 Werner Punz wrote: > https://issues.apache.org/jira/browse/MYFACES-4565 is fixed, but @Volodymyr > Siedlecki <[email protected]> please check whether it is fixed > for you. > > > Am Do., 16. Feb. 2023 um 10:34 Uhr schrieb Werner Punz < > [email protected]>: > > > https://issues.apache.org/jira/browse/MYFACES-4565 @Volodymyr Siedlecki > > <[email protected]> please have a look! > > > > > > Am Do., 16. Feb. 2023 um 10:22 Uhr schrieb Werner Punz < > > [email protected]>: > > > >> Second case might be TempDirFileCacheResourceLoader related. I was not > >> working on this one, but I will file an issue here for me for now, given I > >> know that part a little bit! This resource loader is basically just there > >> for small speed improvements. > >> > >> > >> Am Do., 16. Feb. 2023 um 10:09 Uhr schrieb Werner Punz < > >> [email protected]>: > >> > >>> The ajax test issue is resolved, the test was at fault for having a wait > >>> timeout for findElements of Zero, which causes race conditions! > >>> > >>> The second issue might be a similar race condition issue, given that it > >>> does not show up on my machine! > >>> But someone else should look into it! > >>> > >>> > >>> Am Do., 16. Feb. 2023 um 08:24 Uhr schrieb Werner Punz < > >>> [email protected]>: > >>> > >>>> https://issues.apache.org/jira/browse/MYFACES-4564 > >>>> I have created one for the timeout issue. I will take care of it today. > >>>> > >>>> Werner > >>>> > >>>> Am Do., 16. Feb. 2023 um 08:21 Uhr schrieb Werner Punz < > >>>> [email protected]>: > >>>> > >>>>> Hi I will have a look at this. Re Tabletest, the test probably needs > >>>>> to be adapted here, it still uses timeouts instead of waiting for > >>>>> conditions on the dom, the new JS code is somewhat slower in execution > >>>>> (not > >>>>> by miles, but it is slower given the higher level of abstraction). I > >>>>> will > >>>>> take over the test. It executes fine on my machine, so it is very very > >>>>> likely a timeout issue which needs to be fixed on test level! The second > >>>>> test, someone else has to look into. > >>>>> > >>>>> > >>>>> > >>>>> Am Do., 16. Feb. 2023 um 05:58 Uhr schrieb Volodymyr Siedlecki < > >>>>> [email protected]>: > >>>>> > >>>>>> Hi, > >>>>>> > >>>>>> I was hoping to have a release vote out today, but I've been hit by a > >>>>>> numerous errors when building MyFaces. > >>>>>> > >>>>>> Some have disappeared already (through no action of my own), but the > >>>>>> one I keep getting the most is this ajax one: > >>>>>> > >>>>>> [INFO] [ERROR] Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time > >>>>>> elapsed: 21.554 s <<< FAILURE! - in > >>>>>> org.apache.myfaces.core.integrationtests.ajax.IntegrationTest > >>>>>> [INFO] [ERROR] > >>>>>> org.apache.myfaces.core.integrationtests.ajax.IntegrationTest.testBasicTable > >>>>>> Time elapsed: 6.733 s <<< ERROR! > >>>>>> [INFO] org.openqa.selenium.TimeoutException: Expected condition > >>>>>> failed: waiting for > >>>>>> org.apache.myfaces.core.integrationtests.ajax.IntegrationTest$$Lambda$675/0x000000080085b040@2f54f746 > >>>>>> (tried for 0 second(s) with 500 milliseconds interval) > >>>>>> [INFO] at > >>>>>> org.openqa.selenium.support.ui.WebDriverWait.timeoutException(WebDriverWait.java:87) > >>>>>> ... > >>>>>> [INFO] at > >>>>>> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:169) > >>>>>> [INFO] at > >>>>>> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:595) > >>>>>> [INFO] at > >>>>>> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:581) > >>>>>> [INFO] Caused by: org.openqa.selenium.NoSuchElementException: no such > >>>>>> element: Unable to locate element: {"method":"css > >>>>>> selector","selector":"#head_row1_0"} > >>>>>> [INFO] (Session info: headless chrome=110.0.5481.100) > >>>>>> > >>>>>> > >>>>>> Others: > >>>>>> > >>>>>> CompositeComponentValueChangeListenerTestCase.testSimpleValueChangeListenerNoTarget:336 > >>>>>> » NullPointer > >>>>>> _________ > >>>>>> > >>>>>> [ERROR] Errors: > >>>>>> [ERROR] > >>>>>> > >>>>>> AcidMyFacesRequestTestCase.testAddSimpleCCVDL3:1075->AbstractMyFacesRequestTestCase.processLifecycleExecuteAndRender:225->AbstractMyFacesRequestTestCase.renderResponse:256->AbstractMyFacesTestCase.renderResponse:551 > >>>>>> » Faces java.lang.NullPointerException > >>>>>> _____ > >>>>>> > >>>>>> ——————————————————————————————————————— > >>>>>> Test set: > >>>>>> org.apache.myfaces.view.facelets.tag.composite.CompositeComponentNestedCCTestCase > >>>>>> ——————————————————————————————————————— > >>>>>> Tests run: 14, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > >>>>>> 2.572 s <<< FAILURE! - in > >>>>>> org.apache.myfaces.view.facelets.tag.composite.CompositeComponentNestedCCTestCase > >>>>>> org.apache.myfaces.view.facelets.tag.composite.CompositeComponentMethodExpressionTestCase.testCompositeMethodExpressionTarget2 > >>>>>> Time elapsed: 0.106 s <<< ERROR! > >>>>>> java.lang.NullPointerException > >>>>>> at > >>>>>> org.apache.myfaces.resource.TempDirFileCacheResourceLoader.deleteDir(TempDirFileCacheResourceLoader.java:145) > >>>>>> > >>>>>> > >>>>>> Has anyone encountered these...? > >>>>>> > >>>>>> > >>>>>> > >>>>>> On 2023/02/15 19:30:06 Melloware wrote: > >>>>>> > +1 from me. > >>>>>> > > >>>>>> > On 2/15/2023 10:06 AM, Volodymyr Siedlecki wrote: > >>>>>> > > Hello, > >>>>>> > > > >>>>>> > > Is the code ready for an RC5 release? I saw Thomas and Werner > >>>>>> have > >>>>>> > > some discussion regarding building on windows, but a fix was > >>>>>> just > >>>>>> > > merged in. > >>>>>> > > > >>>>>> > > I would like to merge https://github.com/apache/myfaces/pull/520 > >>>>>> > > (MYFACES-4561), if possible, but it shouldn't hold up RC5. > >>>>>> > > > >>>>>> > > If there's anything else that should be merged in, let me know. > >>>>>> > > > >>>>>> > > Thanks, > >>>>>> > > Volodymyr > >>>>>> > > >>>>>> > >>>>> >
