melloware commented on code in PR #531:
URL: https://github.com/apache/myfaces/pull/531#discussion_r1113056200
##########
impl/src/main/java/org/apache/myfaces/resource/FacesJSResourceLoader.java:
##########
@@ -95,7 +96,7 @@ public InputStream getResourceInputStream(ResourceMeta
resourceMeta)
getHttpServletRequest(FacesContext.getCurrentInstance().getExternalContext());
//name mapping does not happen on meta level
- if(!(libraryName.equals(JsfLibrary.NAMESPACE) &&
+ if(!Objects.equals(libraryName,null) &&
!(libraryName.equals(JsfLibrary.NAMESPACE) &&
Review Comment:
```suggestion
if(!JsfLibrary.NAMESPACE.equals(libraryName)) &&
```
Joshua Bloch always recommends flipping to use the Constant first this way
you can't have an NPE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
