werpu commented on code in PR #539:
URL: https://github.com/apache/myfaces/pull/539#discussion_r1120054925
##########
api/src/client/typescript/faces/impl/AjaxImpl.ts:
##########
@@ -208,7 +208,7 @@ export module Implementation {
/* run through all script tags and try to find the one that includes
faces.js */
const foundStage = ExtDomQuery.searchJsfJsFor(/stage=([^&;]*)/).value
as string;
- return (foundStage in ProjectStages) ? foundStage :
ProjectStages.Production; // MYFACES-4572: default is production
+ return (foundStage in ProjectStages) ? foundStage : null;
Review Comment:
The project started that way due to a standalone implementation for jsf 2.3
and 4.0... for now i will keep it that way... I will probably move the codebase
entirely over after 4.0, but for now I keep it separate because Tobago uses
newer versions, not sure how to handle the 2.3 stuff though (the code generates
frontends for 2.3 and 4.0 out of the same codebase)
I usually downstream the code via npm, from the project into MyFaces and
then automatically copy the code over. This needs to be changed in the long
run, I guess!
Up until now there was no need to do it differently. The second advantage to
this approach is that I can keep the myfaces codebase to a specific jsf_ts
version and swiftly can switch back the version if it fails via npm.
But post 4.0 we can think of a different approach, maybe moving the entire
jsf_ts codebase over into shared and then use the existing approach might be
feasable. Lets think about that once we have 4.0 out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
