werpu commented on PR #547: URL: https://github.com/apache/myfaces/pull/547#issuecomment-1463343106
Merged! Another "improvement" still possible is the elimination of configs, but given the latest changes in the internal config data stuctures, there is little to gain from it no code reduction, no complexity reduction and no speed gain, only a tad closer to the language itself, atm. So not worth the effort for now! In reality the configs just would be replaced by direct assoc arrays and function calls on top of them but the code basically stays the same mostly. So I guess this would not really reduce complexity (config.assign(key1,key2,key3).value = "foobaz" would become assign(assocArray, key1,key2,key3).value = "foobaz"). For debugging purposes - configs now use a pure associative arrays with data only anyway as internal data structures, shifting a little bit away from the pure recursive functional approach used before) Either way should this change be wanted in the long run, the foundations for this are there (and used internally by the Config) A shift to pure assoc arrays probably will make sense as soon as typescript allows constructs like assocArray ?.key1?.key2?.key3 = "value" atm this is a read only operation which forced me to introduce Configs in the code first place! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
