[
https://issues.apache.org/jira/browse/MYFACES-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698880#comment-17698880
]
Werner Punz edited comment on MYFACES-4593 at 3/10/23 11:36 AM:
----------------------------------------------------------------
Turns out in unit testing, that we have applied the wrong error strategy but
for normal server errors it still worked due to the onLoad still called and
onError not called anymore going into the response chain...
Pure luck, I will fix this nevertheless.
The queue from now on only will be emptied in case of a non recoverable client
error which might make the queue unstable, timeouts for instance which used to
clear the queue wont do that anymore. Cancel atm still does (but that is not
used atm)
Exceptions thrown before and until the request is started in are treated as
client errors and clear the queue and throw an exception upwards to the caller!
Server side exceptions never clear the queue... just as per spec.
Should not change anything to the state comitted, due to the bug/behavior I
discovered, but this needs a code cleanup!
Unit tests will be added as well which simulate a 403 error to cover http
errors in the testing!
was (Author: werpu):
Turns out in unit testing, that we have applied the wrong error strategy but
for normal server errors it still worked...
Pure luck, I will fix this nevertheless.
The queue from now on only will be emptied in case of a non recoverable client
error which might make the queue unstable, timeouts for instance which used to
clear the queue wont do that anymore. Cancel atm still does (but that is not
used atm)
Exceptions thrown before and until the request is started in are treated as
client errors and clear the queue and throw an exception upwards to the caller!
Server side exceptions never clear the queue... just as per spec.
Should not change anything to the state comitted, due to the bug/behavior I
discovered, but this needs a code cleanup!
Unit tests will be added as well which simulate a 403 error to cover http
errors in the testing!
> Wrong Error recovery strategy - See also
> https://github.com/jakartaee/faces/issues/1800
> ---------------------------------------------------------------------------------------
>
> Key: MYFACES-4593
> URL: https://issues.apache.org/jira/browse/MYFACES-4593
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 4.0.0
> Reporter: Werner Punz
> Assignee: Werner Punz
> Priority: Major
>
> While investigating a regression bug on the new 4.0.1 codebase in the error
> recovery section I found an issue we have had for a long time.
> We have applied the wrong error recovery strategy. To recover the queue is
> cleared,
> however the jsdoc says otherwise, that every element must be processed.
>
> I need to provide a testcase to the TCK and then will fix it in our codebase.
> Sine the TCK did not cover it.
>
> Makes the code also a little bit leaner on the error handling side.
> See also [https://github.com/jakartaee/faces/issues/1800]
> I will fix this on both ends, the TCK and our codebase for 4.0.1, wont be
> finished very likely today with it. So please wait until monday in the worst
> case!
> This also will fix the regression bug I have discovered!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
