melloware commented on code in PR #565:
URL: https://github.com/apache/myfaces/pull/565#discussion_r1161152278
##########
extensions/quarkus/deployment/src/main/java/org/apache/myfaces/core/extensions/quarkus/deployment/MyFacesProcessor.java:
##########
@@ -788,10 +792,20 @@ else if (ai.target().asMethod().returnType().kind() ==
Type.Kind.PARAMETERIZED_T
// register type
reflectiveClass.produce(new ReflectiveClassBuildItem(true, false,
typeName));
// and try to register the ClientProxy
- reflectiveClass.produce(new ReflectiveClassBuildItem(true, false,
typeName + "_ClientProxy"));
+ if (shouldProxy(typeName))
+ {
+ reflectiveClass.produce(new ReflectiveClassBuildItem(true,
false, typeName + "_ClientProxy"));
+ }
}
}
+ boolean shouldProxy(String typeName)
+ {
+ return !(typeName.startsWith("java.lang")
+ || typeName.startsWith("java.util")
+ || typeName.startsWith("jakarta.faces"));
Review Comment:
It's only for the ClientProxy versions of the beans and I dumped out from
Quarkus which jakarta beans were found and which were alerted to not have
ClientProxy objects. I will run some more tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
