volosied commented on code in PR #607:
URL: https://github.com/apache/myfaces/pull/607#discussion_r1364504418
##########
impl/src/main/java/org/apache/myfaces/view/facelets/PartialStateManagementStrategy.java:
##########
@@ -642,14 +642,25 @@ public void invokeContextCallback(FacesContext context,
UIComponent target)
{
try
{
- target.getChildren().add(childIndex, child);
+ UIComponent parent = target;
+ UIComponent dup = parent.getChildren().get(childIndex);
+ if (child.getId().equals(dup.getId())) // avoid
DuplicateIdException - myfaces-4623
Review Comment:
Maybe I should check for
`dup.getAttributes().get(ComponentSupport.MARK_CREATED)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
