werpu commented on PR #634:
URL: https://github.com/apache/myfaces/pull/634#issuecomment-1776589782
Not needed: if (item && item.type &&
(item.type.toLowerCase() == "submit" ||
item.type.toLowerCase() == "button" )) {
The original behavior is somewhat different anyway... i just changed it
somehow for the new code to cover more elements (aka every element)
Hence I never have issued a pr for the old code it does not expose the
problem!
Either way we theoretically could unify the behavior for all branches, the
old code and new code that would be feasible, if wanted, given this is a non
standard behavior we are free here to do whatever we want!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
