github-advanced-security[bot] commented on code in PR #4634:
URL: https://github.com/apache/myfaces-tobago/pull/4634#discussion_r1420732892
##########
tobago-theme/tobago-theme-standard/src/main/ts/tobago-sheet.ts:
##########
@@ -439,50 +406,42 @@
if (this.id === id) { // is a Faces element id, but not a technical id
from the framework
console.debug(`[tobago-sheet][complete] Update after faces.ajax
complete: #${id}`); // @DEV_ONLY
- const sheet = document.getElementById(id);
- sheet.id = `${id}::lazy-temporary`;
+ update.id = update.id + Sheet.SUFFIX_LAZY_UPDATE; //hide from
faces.js
- const page = Page.page(this);
- page.insertAdjacentHTML("beforeend", `<div id="${id}"></div>`);
- const sheetLoader = document.getElementById(id);
+ this.sheetLoader = document.createElement("div");
+ this.sheetLoader.innerHTML = update.textContent;
Review Comment:
## DOM text reinterpreted as HTML
[DOM text](1) is reinterpreted as HTML without escaping meta-characters.
[Show more
details](https://github.com/apache/myfaces-tobago/security/code-scanning/63)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
