bohmber commented on code in PR #4747:
URL: https://github.com/apache/myfaces-tobago/pull/4747#discussion_r1431888990


##########
tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISheet.java:
##########
@@ -84,24 +84,17 @@ public abstract class AbstractUISheet extends AbstractUIData
   private transient MeasureList columnLayout;
   private transient boolean autoLayout;
   private transient boolean lazyUpdate;
+  private transient int lazyFirstRow;
 
   private transient Grid headerGrid;
 
   @Override
   public void encodeAll(FacesContext facesContext) throws IOException {
 
     if (isLazy()) {
-      if (getRows() == 0) {
-        LOG.warn("Sheet id={} has lazy=true set, but not set the rows 
attribute!", getClientId(facesContext));
-      }
-      if (getShowRowRange() != ShowPosition.none) {

Review Comment:
   Do we really want to delete the other warnings?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to