[
https://issues.apache.org/jira/browse/MYFACES-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807243#comment-17807243
]
Milan Siebenbürger commented on MYFACES-4648:
---------------------------------------------
yes, mojarra returns an empty collection in both cases - so we should remove
the FacesException throwing as well.
in the second case (with user specifying) there is a slight difference - in the
Mojarra implementation the result is a HashMap filled with empty HashSets (one
for each user). In the MyFaces implementation, the result is just an empty
HashMap. That's fine with me, but if you want, I could change it.
> PushContextImpl - different behaviour when socket is not connected
> ------------------------------------------------------------------
>
> Key: MYFACES-4648
> URL: https://issues.apache.org/jira/browse/MYFACES-4648
> Project: MyFaces Core
> Issue Type: Task
> Components: General
> Affects Versions: 4.0.1, 4.0.2, 4.1.0, 5.0.0
> Reporter: Milan Siebenbürger
> Priority: Minor
>
> Hi,
> when sending a message via PushContextImpl, the behaviour differs when using
> methods with or without user specification.
> A new FacesException is thrown when the send() method is used without a user
> specification and without an open channel:
> {code:java}
> throw new FacesException("CDI bean not found for push message");{code}
> When using send() with a user specified, an empty HashMap is returned.
>
> I think the behavior should be the same - either Exception (not recommended)
> or an empty result.
>
> What do you think about this? I am able to prepare a PR (for whatever version
> you need), but let me know what result you chose.
>
> Br
> Milan
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
