2.3 does not have the new TS code, it still is based on the old code. But for maintenance reasons, some code was dropped which was not used anymore, aka branches covering blackberry behavior and other outdated browsers!
I doubt they are the reasons for the TCK failure, but if there is one caused by JS we have to look into it. Am Mi., 12. Juni 2024 um 15:24 Uhr schrieb Volodymyr Siedlecki < [email protected]>: > The 2.3.x JS code was updated here: > > https://github.com/apache/myfaces/pull/451 > > However, I think the TCK failures are caused by simple errors, not newer > syntax. > > Volodymyr > > On 2024/06/11 21:31:23 Thomas Andraschko wrote: > > 2.3.x shouldnt have new js code, right? > > > > Melloware Inc <[email protected]> schrieb am Di., 11. Juni 2024, > 22:37: > > > > > I think these HTMLUnit ones are related to the new JS code and I think > the > > > tests have been updated in newer TCK's to not use HTMLUnit i think. > > > > > > On Tue, Jun 11, 2024 at 3:47 PM Volodymyr Siedlecki < > [email protected]> > > > wrote: > > > > > >> Hello, > > >> > > >> Sorry for the long delay. I'm starting to get results for the > > >> 2.3.11-snapshot back. > > >> > > >> Current tests that fail: > > >> > > >> ee.jakarta.ee4j8.cts.liberty_fat.jsf_api_javax_faces_application FAT > tests > > >> com.sun.ts.tests.jsf.api.javax_faces.application.resource.URLClient > > >> resourceGetRequestPathLibTest > > >> resourceGetRequestPathTest > > >> resourceToStringTest > > >> > com.sun.ts.tests.jsf.api.javax_faces.application.resourcewrapper.URLClient > > >> resourceWrapperGetRequestPathLibTest > > >> resourceWrapperGetRequestPathTest > > >> ee.jakarta.ee4j8.cts.liberty_fat.jsf_spec FAT tests > > >> com.sun.ts.tests.jsf.spec.ajax.keyword.URLClient > > >> ajaxAllKeywordTest > > >> ajaxFormKeywordTest > > >> ajaxNoneKeywordTest > > >> ajaxThisKeywordTest > > >> com.sun.ts.tests.jsf.spec.ajax.tagwrapper.URLClient > > >> ajaxTagWrappingTest > > >> com.sun.ts.tests.jsf.spec.render.commandlink.URLClient > > >> clinkRenderDecodeTest > > >> clinkRenderEncodeTest > > >> clinkRenderPassthroughTest > > >> com.sun.ts.tests.jsf.spec.view.protectedview.URLClient > > >> viewProtectedViewSameWebAppAccessTest > > >> > > >> The latter test seems to fail because of JavaScript. For example: > > >> > > >> AssertionFailure: test result: Failed. Test case throws exception: > > >> com.gargoylesoftware.htmlunit.ScriptException: syntax error (script in > > >> http://localhost:9080/jsf_render_clink_web/faces/encodetest.jsp from > > >> (16, 213) to (99, 1)#22) > > >> test result: Failed. Test case throws exception: > > >> com.gargoylesoftware.htmlunit.ScriptException: syntax error (script in > > >> http://localhost:9080/jsf_render_clink_web/faces/encodetest.jsp from > > >> (16, 213) to (99, 1)#22) > > >> > > >> The rest of the tests should finish up later in the day. > > >> > > >> Thanks, > > >> Volodymyr > > >> > > >> On 2024/05/08 17:49:46 Volodymyr Siedlecki wrote: > > >> > Hi, > > >> > > > >> > I've been focused on one other work, but I'm shifting priorities > and am > > >> starting to look into a release. > > >> > > > >> > I'm first running the TCK against the current 2.3.11 snapshot. I'll > > >> share the results once I have them. > > >> > > > >> > Thanks, > > >> > > > >> > Volodymyr > > >> > > > >> > On 2024/04/22 14:59:55 Melloware Inc wrote: > > >> > > Thank you for looking into this! > > >> > > > > >> > > On Mon, Apr 22, 2024 at 10:39 AM Volodymyr Siedlecki < > > >> [email protected]> > > >> > > wrote: > > >> > > > > >> > > > Hi, > > >> > > > > > >> > > > I can look into doing releases for both. > > >> > > > > > >> > > > Only concern I have is that there may be TCK failures in the > > >> current 2.3 > > >> > > > branch. I tried to do a release sometime last year, but > discovered > > >> a number > > >> > > > of failures. I'll run another build with teh current snapshot > to > > >> see if > > >> > > > there are still there. > > >> > > > > > >> > > > Although, it's possible the failures may have been > > >> infrastructure/network > > >> > > > related? > > >> > > > > > >> > > > I'll let you know more once I found out. > > >> > > > > > >> > > > Best, > > >> > > > Volodymyr > > >> > > > > > >> > > > On 2024/04/22 13:56:54 Melloware Inc wrote: > > >> > > > > Hey team, > > >> > > > > > > >> > > > > I know we are slowing down stopping on the 2.3.x branch but > one > > >> last > > >> > > > > release since it's been a year would be great. We have one bug > > >> with > > >> > > > > PrimeFaces around SearchExpressions which has been fixed but > not > > >> released > > >> > > > > in 2.3 and 2.3-next that is going to cause a lot of heartache > > >> upgrading > > >> > > > to > > >> > > > > PF14. > > >> > > > > > > >> > > > > Volodymyr, I know this burden is on you and sorry in advance > for > > >> > > > asking. I > > >> > > > > know the effort it takes. > > >> > > > > > > >> > > > > Mello > > >> > > > > > > >> > > > > -- > > >> > > > > ============================== > > >> > > > > Melloware > > >> > > > > [email protected] > > >> > > > > http://melloware.com > > >> > > > > ============================== > > >> > > > > > > >> > > > > > >> > > > > >> > > > > >> > > -- > > >> > > ============================== > > >> > > Melloware > > >> > > [email protected] > > >> > > http://melloware.com > > >> > > ============================== > > >> > > > > >> > > > >> > > > > > > > > > -- > > > ============================== > > > Melloware > > > [email protected] > > > http://melloware.com > > > ============================== > > > > > >
