volosied commented on PR #748: URL: https://github.com/apache/myfaces/pull/748#issuecomment-2341865876
As mentioned, if you apply this fix, the test still fails because of the JavaScript exception I posted in the description. The websocket element is outside the form, and the JavaScript code throws an exception. The element is generated here: https://github.com/apache/myfaces/blob/b062baf626ff40e44c74baaed41a00a5c060a9d6/impl/src/main/java/org/apache/myfaces/push/WebsocketComponentRenderer.java#L92-L109 Generated HTML: ``` <div id="j_id_c" style="display:none"></div> ``` The form check should be ignored for this scenario -- perhaps we can add a special flag in the ID so that the form check is skipped? Or how can the JavaScript know to ignore this element ahead of time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
