volosied commented on PR #806: URL: https://github.com/apache/myfaces/pull/806#issuecomment-2491598928
I see this as more of a convenience. The spec describes the search algorithm here: https://jakarta.ee/specifications/faces/4.1/apidocs/jakarta.faces/jakarta/faces/component/search/searchexpressionhandler However, it also states "The search algorithm must operate as follows, **though alternate algorithms may be used as long as the end result is the same:**" If the component can't be found, then it will throw an exception, but, in my opinion, it should keep searching, if possible to find the component. As for the code, we do a bottom - up search (see this [line](https://github.com/apache/myfaces/blob/173739656b99a06b67aa493084db5c2a41c1f4cf/impl/src/main/java/org/apache/myfaces/component/search/SearchExpressionHandlerImpl.java#L535C1-L535C70)) if we can't find the component, should we use try from the root instead? Let me know what you think. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
