[ 
https://issues.apache.org/jira/browse/MYFACES-4706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925014#comment-17925014
 ] 

Werner Punz edited comment on MYFACES-4706 at 2/7/25 7:54 PM:
--------------------------------------------------------------

We have basically 2 major codebases 
 * 4.x and 5.x are exactly identical ( new typescript codebase) 
 * 2.x is the old one 2.3-next is the old one with the legacy support ripped out
 * and 3.x is the old one with the jakarta namespace and minor refactorings!

the new typescript codebase also can support older jsf versions, because my 
original intention was to replace the old code entirely,  but it was decided 
not to drag the new codebase into the existing branches due to customer support 
concerns, which I understand. Hence this weird 3.x state was the result which 
is 2x with jakarta but not entirely!

I hope this clears things up!

Now there are several possible ways forward

a) drop the old codebase and replace it with the new one entirely, but out of 
scope for understandable reasons (no need for further discussion)

b) Leave it as is, and at one point in time the 2.x codebase will fade away 
that leaves us withg the 3.x codebase as only legacy one

Both codebases are close enough that smaller fixes are a non issue, the biggest 
issue you have to be aware are the namespaces, the refactorings are minor!

c) Introduce the solution I have with the new codebase with dynamic namespace 
resolution

also doable, but we do not have the extensive test coverage on the old codebase 
like on the new one, so there might be errors introduced, this needs extensive 
testing afterwards

d) undo the smaller refactorings I did on the 3.x codebase so that the file 
locations match, but that does not resolve the issue, that both codebases use 
different namespaces, so file differences always will be present and you have 
to be aware of them when fixing things!

I can live with either solution!

 


was (Author: werpu):
We have basically 2 major codebases 
 * 4.x and 5.x are exactly identical ( new typescript codebase) 
 * 2.x is the old one 2.3-next is the old one with the legacy support ripped out
 * and 3.x is the old one with the jakarta namespace and minor refactorings!

the new typescript codebase also can support older jsf versions, because my 
original intention was to replace the old code entirely,  but it was decided 
not to drag the new codebase into the existing branches due to customer support 
concerns, which I understand. Hence this weird 3.x state was the result which 
is 2x with jakarta but not entirely!

I hope this clears things up!

 

> Sync jsf.js code between 2.3 and 3.0
> ------------------------------------
>
>                 Key: MYFACES-4706
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4706
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 3.0.2
>            Reporter: Volodymyr Siedlecki
>            Assignee: Werner Punz
>            Priority: Major
>
> MYFACES-4522 synced up the javascript code between 2.3 and 2.3-next. 
> However, 2.3 and 3.0 branches are basically the same.  Therefore, the changes 
> to 2.3 should be applied to 3.0.   Support-wise, it would be easier since 
> they would share the same code base.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to