[ https://issues.apache.org/jira/browse/MYFACES-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Werner Punz reopened MYFACES-4715: ---------------------------------- > AjaxScriptBuilder needs code overhaul > ------------------------------------- > > Key: MYFACES-4715 > URL: https://issues.apache.org/jira/browse/MYFACES-4715 > Project: MyFaces Core > Issue Type: Improvement > Affects Versions: 4.0.0, 4.1.0 > Reporter: Werner Punz > Priority: Minor > > The AjaxScriptBuilder class is used as a code generator for inline code for > The command script render and behavior renderer. Unfortunately the command > script renderer defines per spec a javascript parameter variable which then > is used in the code the script generator generates. Now the current > implementation is subopimal, because it defines one js variable in one class > and then the generator recycles that without a clear connection in the code > in another class (there is a connection by passing the user parameters > variable) > Given the structure of the generator we could add this meta information one > way or the other by extending the init, but I think the generator needs a > complete overhaul anyway, what it does, basically "screams" for a builder > pattern, you pass a set of parameters and then in the end just say build code > more or less! > Rewriting the script builder might be a small but vital improvement! > -- This message was sent by Atlassian Jira (v8.20.10#820010)