henningn commented on PR #6436: URL: https://github.com/apache/myfaces-tobago/pull/6436#issuecomment-2897595369
Since review: * FilteredSelectItems renamed to SelectItemsFiltered * missingSelected list renamed to deferredSelected list * updateDeferredSelectItems is now only called in the decode method * The getItemsList() of AbstractUISelectOne/ManyList is moved to AbstractUISelectItemsFiltered, to avoid duplicate code * add getFilteredItemList() method, which only return the filtered items (without deferred). With this method, the getDeferredSelectedValues() method can be private and the logic is within the AbstractUISelectItemsFiltered class. * impl SearchOnce class to execute the findChild() method only once per life cycle * put isReadonlyState() and isDisabledState() to the AbstractSelectOne/ManyList class * delay and min-chars are now data attributes to match HTML spec. * remove component.setImmediate(true) for decoding * There is no use of the stream() API anymore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org