melloware commented on code in PR #935:
URL: https://github.com/apache/myfaces/pull/935#discussion_r2542515927
##########
extensions/quarkus/deployment/src/main/java/org/apache/myfaces/core/extensions/quarkus/deployment/MyFacesProcessor.java:
##########
@@ -232,15 +231,19 @@ void buildFeature(BuildProducer<FeatureBuildItem> feature)
@BuildStep
void buildServlet(WebMetadataBuildItem webMetaDataBuildItem,
- BuildProducer<FeatureBuildItem> feature,
Review Comment:
fetaure is never used in this build step
##########
extensions/quarkus/deployment/src/main/java/org/apache/myfaces/core/extensions/quarkus/deployment/MyFacesProcessor.java:
##########
@@ -232,15 +231,19 @@ void buildFeature(BuildProducer<FeatureBuildItem> feature)
@BuildStep
void buildServlet(WebMetadataBuildItem webMetaDataBuildItem,
- BuildProducer<FeatureBuildItem> feature,
BuildProducer<ServletBuildItem> servlet,
- BuildProducer<ListenerBuildItem> listener) throws
IOException
+ BuildProducer<ListenerBuildItem> listener)
Review Comment:
this method does not throw IOException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
