[
https://issues.apache.org/jira/browse/MYFACES-4749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18077899#comment-18077899
]
Werner Punz edited comment on MYFACES-4749 at 5/3/26 2:12 PM:
--------------------------------------------------------------
Number of unit tests on the codebase are ramped up from roughly 240 to now 338
Code coverage statistics for the Ajax part:
!image-2026-05-03-16-12-26-956.png|width=948,height=764!
was (Author: werpu):
Number of unit tests on the codebase are ramped up from roughly 240 to now 338
Code coverage statistics for the Ajax part:
-------------------------------|---------|----------|---------|---------|-------------------------------------------------
File | % Stmts | % Branch | % Funcs | % Lines |
Uncovered Line #s
-------------------------------|---------|----------|---------|---------|-------------------------------------------------
All files | 95.07 | 80.76 | 95.46 | 95.32 |
typescript | 100 | 87.5 | 100 | 100 |
mona_dish_shim.ts | 100 | 87.5 | 100 | 100 | 37
typescript/@types/definitions | 0 | 0 | 0 | 0 |
index.d.ts | 0 | 0 | 0 | 0 |
modules.d.ts | 0 | 0 | 0 | 0 |
typescript/api | 87.7 | 77.94 | 92.85 | 86.4 |
_api.ts | 84.04 | 69.44 | 91.3 | 82.27 |
261-262,265,268,296-308,312
faces.ts | 100 | 87.5 | 100 | 100 | 1,44
jsf.ts | 100 | 87.5 | 100 | 100 | 1,53
typescript/impl | 94.58 | 78.51 | 95.89 | 95.51 |
AjaxImpl.ts | 95.31 | 77.38 | 92.85 | 95.33 |
440-447,525-528,571,752
PushImpl.ts | 93.33 | 80.39 | 100 | 95.86 |
155,278,288-289,335
typescript/impl/core | 99.27 | 77.77 | 85.71 | 99.27 |
Const.ts | 100 | 86.66 | 100 | 100 | 1,213
ImplTypes.ts | 88.88 | 66.66 | 66.66 | 87.5 | 40
typescript/impl/i18n | 100 | 75 | 100 | 100 |
Messages.ts | 100 | 75 | 100 | 100 | 1-118
typescript/impl/util | 94.21 | 82.38 | 92.8 | 94.6 |
Assertions.ts | 100 | 87.87 | 100 | 100 |
1,80-91
AsyncRunnable.ts | 81.25 | 75 | 87.5 | 81.25 |
134-136
ExtDomQuery.ts | 91.17 | 81.53 | 95 | 92 |
79,98,103,116,124,194,316-317
FileUtils.ts | 97.91 | 86.36 | 94.44 | 100 |
1,68,105
HiddenInputBuilder.ts | 100 | 76.47 | 100 | 100 |
1,67,79-93
IListener.ts | 0 | 0 | 0 | 0 |
Lang.ts | 91.35 | 81.08 | 78.26 | 91.17 |
33-34,177-179,271
XhrQueueController.ts | 100 | 81.81 | 100 | 100 | 1,104
typescript/impl/xhrCore | 96.46 | 82.67 | 98.03 | 96.32 |
ErrorData.ts | 100 | 75 | 100 | 100 |
1,95-98,125
EventData.ts | 91.3 | 83.33 | 50 | 91.3 | 39-40
IResponseProcessor.ts | 0 | 0 | 0 | 0 |
RequestDataResolver.ts | 98.3 | 78.94 | 100 | 98.24 | 172
Response.ts | 98.61 | 92.59 | 100 | 98.59 | 170
ResponseDataResolver.ts | 100 | 77.77 | 100 | 100 | 1-65
ResponseProcessor.ts | 98.76 | 85.71 | 100 | 98.71 |
97,139
XhrFormData.ts | 98.03 | 89.47 | 100 | 97.72 | 159
XhrRequest.ts | 91.71 | 81.01 | 97.29 | 91.35 |
199-200,206-211,254-257,263,344-345,405-406,466
typescript/myfaces | 90 | 74.28 | 100 | 89.79 |
OamSubmit.ts | 90 | 74.28 | 100 | 89.79 |
45,65,92,118,123
-------------------------------|---------|----------|---------|---------|-------------------------------------------------
> Update the typescript compiler and build codebase to Typescript 6.0
> -------------------------------------------------------------------
>
> Key: MYFACES-4749
> URL: https://issues.apache.org/jira/browse/MYFACES-4749
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.0.4, 4.1.3
> Reporter: Werner Punz
> Assignee: Werner Punz
> Priority: Major
> Attachments: image-2026-05-03-16-12-26-956.png
>
>
> While functionally nothing should change, typescript 6 is an important
> stepping stone towards Typescript 7 which will be a Rust rewrite of the
> entire compiler codebase. With it there will be some breaking changes
> regarding module support which TS 6 already implements. The bundling now is
> offloaded into a separate bundler via the bundler directive and webpack is
> our bundler and has been quite a while. With the the node module support will
> get breaking changes in the build process.
> I have already prepared a new TS6 enabled version in my github project and
> this needs to be upstreamed now into myfaces, however here also some changes
> need to be performed on the setup for the build regarding the module
> resolution changes!
> Also several things have been fixed and AI has been introduced in my private
> workflow on the downstram project
> Updated to the latest version of the codebase
> * Websocket error and recovery lifecycle is now fixed and according to the
> spec (there were several minor issues regarding recovery and event callback)
> * In some core classes the readability has been improved
> * 404 now is properly reported, the old code reported an "illegal XML
> Exception" instead
> * File Upload had an explicit content type set, which can bring the browser
> into an unstable state (this is not set by the browser) - the browser now
> sets the content type for file upload itself, verified on a browser that this
> works!
> * Around 100 tests added which fortify now the push lifecycle and cover now
> up until now uncovered code!
> * Ai disclaimers and markers added for code added and touched by AI toolings
> to be in accordance with the ASF guidelies
> Full detailed changelist can be found in the downstream project:
> [https://github.com/werpu/jsfs_js_ts]
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
