exabrial commented on PR #1123:
URL: https://github.com/apache/myfaces/pull/1123#issuecomment-6477991276

   Yes definitely on 3.0.x. Same exact problem. Let me see if I can apply my PR 
directly without rebranching.
   
   4.0.x/4.1.x have an interesting DOM check:
   
   ```
   DQ.byId(finalIdentifier).isPresent()
   ```
   
   full code:
   
   ```
   return DQ.byId(finalIdentifier).isPresent() ? finalIdentifier : 
componentIdToTransform;
   ```
   
   While this _might_ prevent the bug from happening, it depends on the client 
side page state.... The DOM check seems a bit dangerous, as it makes the client 
behave different depending on the f:ajax execution order.
   
   The new guard should probably be in those branches... probably. but it might 
be best to figure out why the DOM check is there first. I actually don't the 
newer version so I'm not as familiar.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to