melloware opened a new pull request, #1145: URL: https://github.com/apache/myfaces/pull/1145
https://issues.apache.org/jira/browse/MYFACES-4785 Migrates the test suite to JUnit 6 (6.1.3) using OpenRewrite, bumps Surefire to 3.6.1, and fixes the breakage the automated migration introduced. ## Fixes after OpenRewrite - `UIDataTest` restored to `public` (its `RowData` is used by `UIRepeatTest` in another package). - Subclass overrides updated to match renamed base test methods (`StateManagerWithFaceletsClientSideTest`, `Html{Body,SelectManyCheckbox,SelectOneRadio}ClientBehaviorRendererTest`). - `assertDoesNotThrow` lambdas that assigned captured locals now return values or use effectively-final copies (`ViewHandlerImplTest`, `HtmlTableRendererTest`, `ResponseWrapperSwitchTest`, `AbstractClientBehaviorTestCase`); the worker-thread blocks in `LRULinkedHashMapTest` go back to try/catch. - `ResourceLoaderUtilsTest.parseDateHeader`: restored the 2000 ms delta the rewrite dropped. - `UIComponentBaseTest.processDecodesCallsRenderResoponseIfDecodeThrowsException`: restored the original structure. Note: this test already passed without testing anything before this change (`expectLastCall()` throws `IllegalStateException`, which satisfies `assertThrows`). Worth a follow-up. - Quarkus showcase stays on JUnit 5.13.4: Quarkus 3.27.1 (`quarkus-junit5`) ships the JUnit 5 platform, and mixing in Jupiter 6 fails test discovery. ## Testing `mvn install` passes locally: impl 1787 tests, 0 failures. The Quarkus showcase passes too (1 test was already `@Disabled`). 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
