On Sat, Jul 1, 2017, at 06:57 PM, amit mehta wrote:

> So, what is the way of working for "rework on pull request"

Pierre's answer is correct. But you seemed to already have a PR open
(https://github.com/apache/mynewt-core/pull/358/). You don't need to do
everything again, you just add the commit to that same branch you used
(mybranch), push, and it automatically shows up on the PR.

PS: "mybranch" is not supposed to be used literally, you should use a
descriptive name like "add-eclipse-mqtt" or similar. You could still do
it now by running "git checkout -b add-eclipse-mqtt" while in "mybranch"
but then you'd have to open a new PR, and so on, so keep it in mind for
future PRs!

> I did ask this same question on mynewt slack, but didn't get any
> response; weekend effect I guess :)

Yup, it probably is, but Slack and IRC are not real-time. You have to be
more patient!

Cheers,
Fabio Utzig

Reply via email to