Sounds good to me. Though Id say it might make sense to keep old names around with the compat mcu for a release or something? With some deprecation message and no updates for that cycle, and have the new names with the new mcu
On Wed, Aug 22, 2018 at 7:50 AM Miguel Azevedo <[email protected]> wrote: > I agree that we should use the board name instead of the kit name, if dk is > the same board as pdk. > > On Wed, 22 Aug 2018, 15:12 Andrzej Kaczmarek, < > [email protected]> > wrote: > > > Hi all, > > > > Since nRF52840 DK is available for quite some time now, I was going to > > rename "nrf52840pdk" to "nrf52840dk" so it matches current version. > > However, it is a good moment to change naming scheme for all dev kits > > from Nordic and use board name (e.g. PCA10056) instead of dev kit name > > (e.g. nRF52840 DK). There are at least two good reasons for this: > > > > 1. avoid possible renames in future once new revision of dev kit is > > launched (PDK -> DK) since this is the same board, just with a > > different revision > > 2. make selection of proper BSP easier since each board has its name > > clearly visible on a sticker (note that BSP description states both > > names) > > > > I created a PR which does such rename: > > https://github.com/apache/mynewt-core/pull/1348 > > > > Thoughs? Are there any good reasons why we should not rename it? > > (except for historical reasons :P) > > > > Best, > > Andrzej > > >
