ccollins476ad commented on a change in pull request #2: Support verification of
encrypted images
URL: https://github.com/apache/mynewt-artifact/pull/2#discussion_r297778632
##########
File path: image/create.go
##########
@@ -38,7 +38,7 @@ import (
type ImageCreator struct {
Body []byte
Version ImageVersion
- SigKeys []sec.SignKey
+ SigKeys []sec.PrivSignKey
Review comment:
By "Pub" I mean the public component of the key; the part that you use to
verify a signature. Do you think `PrivSignKey` / `PubSignKey` is not a good
way to name these types?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
