utzig commented on a change in pull request #2: Support verification of
encrypted images
URL: https://github.com/apache/mynewt-artifact/pull/2#discussion_r297782191
##########
File path: image/create.go
##########
@@ -38,7 +38,7 @@ import (
type ImageCreator struct {
Body []byte
Version ImageVersion
- SigKeys []sec.SignKey
+ SigKeys []sec.PrivSignKey
Review comment:
`PubKey` would be ok for the verification, or `VerifyKey` (which sounds a
bit weird!). I just mentioned it because saying that it is private is like
saying: "look this number is prime, AND it also is only divisible by 1 and
itself". All those name changes don't bring extra information. Although I would
not mind if you prefer this way, since it's done already! ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
