Thanks for noticing. Opened this PR for it: https://github.com/apache/mynewt-core/pull/2044 <https://github.com/apache/mynewt-core/pull/2044>
We do recommend creating PRs for the fixes; those are easier to bring in. https://cwiki.apache.org/confluence/display/MYNEWT/Submitting+Pull+Requests <https://cwiki.apache.org/confluence/display/MYNEWT/Submitting+Pull+Requests> > On 15 Oct 2019, at 23.30, myn...@hackdaworld.org wrote: > > Hi all, > > if you want to build a lora node firmware > > pkg.deps: > - "@apache-mynewt-core/net/lora/node" > > without LORA_NODE_CLI support > > syscfg.vals: > LORA_NODE_CLI: 0 > LORA_NODE_LOG_CLI: 0 > > and (thus) without shell and parse dependency added to your project, you will > get an error like: > > Compiling repos/apache-mynewt-core/net/lora/node/src/lora_cli.c > Error: repos/apache-mynewt-core/net/lora/node/src/lora_cli.c:23:10: fatal > error: shell/shell.h: No such file or directory > #include "shell/shell.h" > ^~~~~~~~~~~~~~~ > compilation terminated. > > The attached patch fixes this issue by checking for LORA_NODE_CLI support > earlier. > > Hope I didn't get anything wrong. > > Best, > Frank > <lora_node_cli_check.patch>
