+1 binding, tested with the latest on. Custom board, everything works well.
Regards, Vipul Rahane On Mon, Mar 23, 2020 at 3:23 AM Szymon Janc <szymon.j...@codecoup.pl> wrote: > Hi Justin, > > On Thursday, 19 March 2020 03:52:51 CET Justin Mclean wrote: > > HI, > > > > Sorry but it’s -1 (binding) as LICENSE file are not correct. > > Uhm, yeah I'll clean that up and we will do rc2. > > > > > I checked: > > - signatures and hashes are fine > > - Years in NOTICE are incorrect > > - LICENSE for blink is fine, other LICENSE files are not (see below) > > - no unexpected binary files > > - all source file have ASF headers, some of them may incorrect headers > > - did not compile from source > > > > For apache-mynewt-newtmgr-1.8.0 the LICENSE list a large number of > things, > > none of which seem to be actually bundled. > > > > the same with apache-mynewt-newt-1.8.0. I also note it does bundle some > > files under the go versions libyaml but not the full list mentioned in > > LICENSE. > > > > A spot check on core LICENSE show some missing or invalid paths e.g > > [1][2][3][4][5][6][7][8][9][10] do these need to be removed from LICENSE? > > Some were removed, some renamed, I'll check that. > > > It also seems to be missing a number of things as well. This fiile*, [11] > > Android Open Source Project, [12] Dialog Semiconductor, [13] Jan Van > > Winkel*, several file copyright PHYTEC Messtechnik GmbH* e.g [14], > several > > files copyright Bosch Sensortec GmbH* eg [15], several file copyright Ac6 > > e.g [16], InvenSense, Inc [17] and several file copyright Embedded > > Microprocessor Benchmark Consortium (EEMBC). They are probably others > and I > > didn’t;t check any ARM or STMircrocontroller files. > > Yes, [15] looks odd with those double licenses although it was clarified > for > header file, but not for .c file in PR [20]. > > > * Which also seem to have an incorrect headers? > > While [15] is indeed odd, what do you mean by incorrect headers in other > files? > > > > > I did the above check by comparing with the 1.5 release as it's LICENSE > file > > is identical, but as the LICENSE file hasn’t changed in 2 year which mean > > there’s probably more to be done and we’ll need to check with an easier > > release (1.3 release?) > > > > It may also be that NOTICE file are incoresst as I some of teh files > added > > are 3rd part file that are Apache licensed. > > So just to be sure, NOTICE should have listed all 3rd party but APL2 > licensed > code, while LICENCE should list all non-APL code? > > > I didn’t check the binaries. > > > > Thanks, > > Justin > > > > 1. hw/bsp/nrf51dk/src/arch/cortex_m0/gcc_startup_nrf51.s > > 2. hw/bsp/stm32l152discovery/src/system_stm32l1xx.c > > 3. hw/bsp/nrf52840pdk/split-nrf52840pdk.ld > > 4. docs/_static/css/bootstrap-3.0.3.min.css > > 5 docs/themes/mynewt/static/js/affix.js > > 6 docs/themes/mynewt/static/js/scrollspy.js > > 7 docs/themes/mynewt/static/fonts/fontawesome-webfont.eot > > 8 docs/themes/mynewt/static/fonts/Inconsolata-Bold.ttf > > 9 docs/themes/mynewt/static/fonts/Lato-Bold.ttf > > 10 hw/mcu/arc/src/ext/sdk > > 11. ./hw/drivers/display/cfb/src/cfb_fonts.c > > 12 ./hw/mcu/dialog/include/DA1469xAB.h > > 13. ./hw/drivers/display/include/display/display.h > > 14. ./hw/drivers/display/cfb/include/display/cfb.h > > 15 ./hw/drivers/sensors/bmp388/src/bmp388_shell.c > > > 16../hw/mcu/stm/stm32wbxx/src/ext/Drivers/CMSIS/Device/ST/STM32WBxx/Source/T > > emplates/gcc/linker/stm32wb55xx_flash_cm4.ld 17 > > ./hw/drivers/sensors/icp101xx/License.txt > > 18 ./apps/coremark/include/core_portme.h > > > [20] https://github.com/apache/mynewt-core/pull/1819 > > -- > pozdrawiam > Szymon Janc > > > > -- Regards, Vipul Rahane
