Hi Justin,
I had a few more questions about your findings, if you don't mind. I
have snipped most of your comments, as there is no doubt about how to
address them.
On Wed, Mar 16, 2016 at 03:41:27PM +1100, Justin Mclean wrote:
> Blinky:
> - README should including instructions on how to compile (but managed
> to compile)
> - not sure that unit test info is correct as newt build unittest gives
> "Error: Target does not specify an app package (target.app)” and newt
> test doesn’t seem to do anything
I just wanted to add a clarification regarding blinky:
Blinky is a bit unusual in that it is not meant to be compilable nor
testable on its own; it depends on libraries in the apache-mynewt-core
package. Blinky is actually just a project skeleton that gets
downloaded by the "newt new" command. This is likely why the "newt test
all" command did not seem to do anything when you ran it - blinky by
itself does not contain any tests.
The point is well taken: we need to make all of the above information
clear in blinky's README.
> Core:
> - LICENSE is missing a number of files. For example from [1] as most
> of those files have BSD licenses but only a small number are listed in
> LICENSE.
([1]=hw/mcu/stm/stm32f4xx/include/mcu/*)
The core LICENSE file references the following directory as part of
STM32CubeF4 (3-clause BSD):
* hw/mcu/stm/stm32f4xx/include/
Are subdirectories generally not considered to be included in such a
reference? It is not a big deal in this case, as the above path only
contains a single entry (the mcu subdirectory). However, I ask because
there are other references in the core LICENSE file that are meant to
include all child subdirectories.
Thanks,
Chris
