Thanks, Justin.  I have confirmed that your findings regarding the
build.sh script are valid, and I will make sure to address them before
the next release.

Chris

On Mon, Mar 21, 2016 at 04:00:48PM +1100, Justin Mclean wrote:
> Hi,
> 
> +1 binding
> 
> I checked (in all artefacts):
> - names contain incubtating
> - signatures good
> - DISCLAIMER exits
> - LICENSE and NOTICE good
> - No unexpected binary files
> - Source files have apache headers
> - Could compile from source (with some issues)
> 
> In newt I ran into a couple of minor issues:
> - repository.yml is missing an Apache header
> - when running build.sh realpath doesn’t exist in OS X. To solve this I brew 
> install coreutils and used grealpath instead.
> - build.sh also failed with an earlier version of go because of this:
>       go version | cut -d ' ' -f 3
>       go1.4.2
> (solved by updating go)
> - would be nice for the build.sh to tell you a little of what was going on 
> when building
> 
> Thanks,
> Justin

Reply via email to