Based on all the comments, etc. (thanks!) here’s what I’ve done: I’ve submitted a pull request against the STM32F repository to add the LED_BLINK_PIN_X defines, and then #define LED_BLINK_PIN LED_BLINK_PIN_1 which solves for leaving the blinky as-is as the “hello world” of MyNewt while still enabling the pin wheel aspect for those that want to make the mods.
I’ve then created a new doc for the site, and a link to it from the STM32f303 page, that describes in detail how to modify the blinky app to be the pinwheel app. I think this is the way to go rather than creating a whole separate app that essentially does the same thing as blinky, just more so. Best regards, dg > On Jun 6, 2016, at 5:38 PM, Christopher Collins <[email protected]> wrote: > > On Mon, Jun 06, 2016 at 12:42:38PM -0700, marko kiiskila wrote: >> I would leave blinky as is. It is beneficial to have a sample that >> shows that you can have applications which don’t need any platform >> specific changes. > > I agree. Blinky is Mynewt's "hello world" applications.hhC, and I think > it is important that it remain as simple as possible. > >> As for the mynewt_pinwheel demo, you could check that into >> mynewt-stm32f3 repository as a separate app. The particular layout of >> those LEDs is specific for the STM32F3 discovery board, so to me it >> would make sense to keep the app in the same repository as the >> matching BSP. >> >> What do you think? > > I'm not David, but that sounds good to me. > > Chris -- David G. Simmons (919) 534-5099 Web • Blog • Linkedin • Twitter • GitHub /** Message digitally signed for security and authenticity. * If you cannot read the PGP.sig attachment, please go to * http://www.gnupg.com/ Secure your email!!! * Public key available at keyserver.pgp.com **/ ♺ This email uses 100% recycled electrons. Don't blow it by printing! There are only 2 hard things in computer science: Cache invalidation, naming things, and off-by-one errors.
signature.asc
Description: Message signed with OpenPGP using GPGMail
