On Mon, Jul 25, 2016 at 08:40:34PM +0300, Johan Hedberg wrote: > Hi, > > On Mon, Jul 25, 2016, Christopher Collins wrote: > > On Mon, Jul 25, 2016 at 10:34:45AM +0300, Johan Hedberg wrote: > >> The following patch failed to update the call to os_mbuf_free_chain() > >> after updating the signature of ble_hs_rx_data: > > > > Thanks Johan. I must have made a git error when I was pushing the > > original changes. Anyway, I have applied the patch. > > Thanks Chris. However, you seem to have lost both the commit message and > author information when applying. git provides the perfect tools for > sending (git send-email) and applying (git am) patches via email which > retain all the essential meta-data. > > The same thing happened the last time someone sent a patch to this list: > > http://mail-archives.apache.org/mod_mbox/incubator-mynewt-dev/201605.mbox/%3ccaexxlla_m-9gyqu_pkzdywhrg9r7r1ooqz-grhf+d3vwc5n...@mail.gmail.com%3E > > If the project will continue accepting patches via email it'd be good if > all maintainers know how to correctly use git for this process. > Requiring contributors to stick to github is also fine, but then it > needs to be stated somewhere.
You are right; sorry about that. I used the "git apply" command rather than "git am". We would like to continue receiving patches via email, so we will need to make an effort to educate the Mynewt committers (including myself!) to use "git am". Thanks, Chris
