Vipul added this code, so check with him. Now that this is a larger
value, I’m not sure we need to rollover the index personally/special
case this.
On 1 Sep 2016, at 10:21, Peter Snyder (JIRA) wrote:
[
https://issues.apache.org/jira/browse/MYNEWT-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456063#comment-15456063
]
Peter Snyder commented on MYNEWT-368:
-------------------------------------
Looking at log.c/log_append(), the following lines reset the log index
when there's more than a ms between log entries.
/* Resetting index every millisecond */
if (g_log_info.li_timestamp > 1000 + prev_ts) {
g_log_info.li_index = 0;
}
Was this necessary? If li_index is 16 bits and there's a fewer
rollovers, do we still need it? We could automatically generate a log
message when a timer or index rollover is detected. Thoughts?
Change logging format
---------------------
Key: MYNEWT-368
URL: https://issues.apache.org/jira/browse/MYNEWT-368
Project: Mynewt
Issue Type: Bug
Components: Newtmgr
Reporter: Sterling Hughes
Assignee: Peter Snyder
Fix For: v1_0_0_beta1
Right now newtmgr has an 8-bit index which goes along with a 64-bit
timestamp. We are having trouble querying logs when time moves
forward, because of the misordering of log entries.
We should change this such that we have a 16-bit log index, which can
be used to query logs remotely. A result of this will be to make the
module an 8-bit value, which it is already assumed to be.
While doing this change, on the FCB implementation, we should also
add a short log entry header (4-bytes), that at least contains the
version of the log format that we are writing, that way when we make
changes in the future to the log format, the code can automatically
wipe this sector and reformat it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
