While mucking about in the source I found a few places where the use of
OS_OK was either returned and checked against a hardcoded zero, or the
other way around, and some function signatures that give os_error_t or int
and return the other. The documentation has similar disconnects in portions
as to what the return type is, and some functions seem to bubble up the
response code from underlying system calls and the type changes as it is
returned.  I'd like to work through fixing these, but I'm not able to find
a single source of truth as to which they should be. Is there currently any
set guidance on this? Or would it be fine if I just made my best guesses
and brought it together as a PR against the github repository?

Thanks for any help you can give on the matter.
- Ben Harper

Reply via email to