Hey Vipul et al, Ive been plugging away at a few sensors (bma250, lis2dh) and so taking a much closer look at this now.
It seems odd to me that sensors are getting pushed all way down to the BSP, only to be created, but not inited. Also why dont BSP then pickup a dependency on all those sensors? I presume Im missing something about the os bringup? Why not generalize to create maybe spi0 os_dev instead of accel os_dev then since.. theres nothing accel specific being done in the bsp? Thanks for any clarification. On Fri, Mar 31, 2017 at 6:19 PM, Vipul Rahane <[email protected]> wrote: > Yes, that’s what I mean’t. Thanks Will. > > -Vipul > > > On Mar 31, 2017, at 5:37 PM, will sanfilippo <[email protected]> wrote: > > > > I presume you mean “was getting too crowded” :-) > > > > Yeah, I copied that bsp to create this other bsp and noticed alot of > sensor dev creates in there. Not a big deal but I think this will make the > code a bit less crowded. > > > > +1 > > > > > >> On Mar 31, 2017, at 5:30 PM, Vipul Rahane <[email protected]> wrote: > >> > >> Hello, > >> > >> I am changing nrf52dk hal_bsp_init() so that it calls > sensor_device_create() instead of creating sensors separately. this is > because hal_bsp_init() was not getting too crowded. > >> > >> Regards, > >> Vipul Rahane > > > >
