Hi Darin, I was wondering if it would be possible to address them in a follow up PR.
Addressed new review comments since Wednesday and updated PR https://github.com/mesos/myriad/pull/123 Regards Swapnil On Fri, Sep 4, 2015 at 9:55 AM, Darin Johnson <[email protected]> wrote: > I've got some more comments but can really respond adequately until > tomorrow due to travel. I'll defer if everyone else is OK with the merge. > Hi All, > > I have address all the review comments I received since the last PR update > on Monday. > The latest updated PR is here https://github.com/mesos/myriad/pull/123 > > I am wondering, if there are no further review comments by Friday, can we > considering merging this pull request ? > > Regards > Swapnil > > > On Mon, Aug 24, 2015 at 7:58 PM, Darin Johnson <[email protected]> > wrote: > > > Swapnil, > > > > Generally no, they don't which makes it confusing and so I asked. > Started > > playing with it, going to be travelling tomorrow but will try out soon. > > > > Darin > > > > > > On Mon, Aug 24, 2015 at 10:50 PM, Swapnil Daingade < > > [email protected]> wrote: > > > > > Hi Darin, > > > > > > Its a dfs path. I tried it on MapRFS. > > > Does hdfs require it to be prefixed by something like hdfs:// ? > > > If yes, I'll make the change. > > > > > > Regards > > > Swapnil > > > > > > > > > On Mon, Aug 24, 2015 at 7:28 PM, Darin Johnson < > [email protected]> > > > wrote: > > > > > > > Question on the yarn.resourcemanager.fs.state-store.uri that's a > local > > fs > > > > in /var/ if that's we're you're keeping the state how is it regained > if > > > the > > > > RM is restarted on a different node in marathon? Haven't read > through > > > all > > > > the code yet but I'm trying to get oriented, sorry. > > > > > > > > On Mon, Aug 24, 2015 at 9:35 PM, Swapnil Daingade < > > > > [email protected]> wrote: > > > > > > > > > Hi All, > > > > > > > > > > Here is a document on how to configure and try out Myriad HA. > > > > > > > > > > > > > > > > > > > > > https://docs.google.com/document/d/1PPqQmiWgCsxrMEq56fNra2Z6JZI8vlF5HK9fHKmA9_Q/edit > > > > > > > > > > Please let me know your thoughts. > > > > > Once I incorporate community feedback and Myriad HA makes it to > > phase1, > > > > > I'll move it to a more > > > > > permanent place like perhaps the wiki. > > > > > > > > > > Regards > > > > > Swapnil > > > > > > > > > > > > > > > > > > > > On Thu, Aug 20, 2015 at 11:39 AM, Darin Johnson < > > > [email protected] > > > > > > > > > > wrote: > > > > > > > > > > > Sweet, look forward to checking it out. > > > > > > Hi All, > > > > > > > > > > > > I have updated my pull request with the complete Myriad HA > > > > implementation > > > > > > rebased > > > > > > on top of the FGS changes here > > > > > > > > > > > > https://github.com/mesos/myriad/pull/123 > > > > > > > > > > > > I am planning to send out another email with details on how to > > > > configure > > > > > > it. > > > > > > > > > > > > Regards > > > > > > Swapnil > > > > > > > > > > > > > > > > > > > > >
