I'm torn about what's the right thing to do here. The file is required for the Myriad UI to work, so it at least needs to be part of released jars. Having it build as part of Groovy could lead to problems with people not having node/npm or gulp or whatever else the build requires. I was poking around git, and perhaps this might be useful.
git update-index --assume-unchanged FILE_NAME I haven't played with it yet to know though. At the very least, I'll run obfuscation as part of the gulp build. On Fri, Oct 16, 2015 at 12:56 PM, Aashreya Shankar <[email protected]> wrote: > I think it got generated when I build it using gulp. I can try to find a > way to remove it. > > On Fri, Oct 16, 2015 at 9:47 AM, Ken Sipe <[email protected]> wrote: > > > It appears to have path references in the source from whoever built it. > > > > we should make generating it part of the build… and it should not be > > checked in. > > > > ken > > > > > On Oct 16, 2015, at 11:12 AM, Jim Klucar <[email protected]> wrote: > > > > > > Also, I'm not finding references to Santosh or ashankar anywhere. Do > you > > > have line numbers? > > > > > > On Fri, Oct 16, 2015 at 12:06 PM, Jim Klucar <[email protected]> wrote: > > > > > >> That's the catch. Generating it isn't part of the build, so if we > don't > > >> check it in, there won't be a UI > > >> > > >> > > >> On Fri, Oct 16, 2015 at 11:40 AM, Ken Sipe <[email protected]> wrote: > > >> > > >>> It was part of your check in:) if it is a generated file we > > shouldn’t > > >>> check it in at all. > > >>> > > >>> ken > > >>>> On Oct 16, 2015, at 10:39 AM, Jim Klucar <[email protected]> wrote: > > >>>> > > >>>> Why were you reviewing that file? That file is cobbled together by > > gulp > > >>>> from all the other .js files. Anything in /public is generated by > > gulp. > > >>>> > > >>>> I searched for santosh and ashankar in my repo and couldn't find > > >>> anything. > > >>>> what branch? > > >>>> > > >>>> > > >>>> On Fri, Oct 16, 2015 at 11:35 AM, Ken Sipe <[email protected]> > wrote: > > >>>> > > >>>>> team, > > >>>>> > > >>>>> I was forced to review myriad.js today… > > >>>>> > > >>>>> there are many references to ashankar and santosh in that file…. > > can > > >>> we > > >>>>> have these removed? > > >>>>> > > >>>>> ken > > >>> > > >>> > > >> > > > > >
