We need to fix the LICENSE, exclude the gradle-wrapper.jar from the tarball, and add build instructions (potentially also on how to download gradle as well) in the README.
Santosh ---------- Forwarded message ---------- From: Justin Mclean <[email protected]> Date: Wed, Nov 18, 2015 at 4:55 PM Subject: Re: [VOTE] Release Apache Myriad 0.1.0 (incubating) To: [email protected] Hi, Sorry but it -1 due to inclusion of a jar in the source release. This issue has come up before on the incubator mailing list e.g. [4]. Other than some minor license issues everything else is good. I checked: - artefact name contains incubating - signatures and hashes good - DISCLAIMER exists - LICENSE has a couple of minor issues - NOTICE good - unexpected binary file in the source release [3] - all source code has Apache headers - Can build from source For the LICENSE: - The appendix part of the LICENSE isn’t correct (i.e. the Apache licence can apply to non ASF licensed software). Best to use the stock one and not modify it [1] - LICENSE mentions sub components but there are none listed - LICENSE is missing normalise.css which is MIT licensed see [2] You may want to consider: - Signing with an apache.org email address - Adding some build instruction to README Thanks, Justin 1. http://www.apache.org/licenses/LICENSE-2.0.txt 2. ./myriad-scheduler/src/main/resources/webapp/css/bootstrap-myriad.css 3../gradle/wrapper/gradle-wrapper.jar 4. http://apache.markmail.org/thread/stygi2hnnovbmf46 --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
