[jira] [Commented] (MYRIAD-184) RM Ports are Hardcoded in NMExecutorCLGenImpl.java

[John Omernik (JIRA)]

    [ 
https://issues.apache.org/jira/browse/MYRIAD-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074202#comment-15074202
 ] 

John Omernik commented on MYRIAD-184:
-------------------------------------

Looking at the code referenced: 

  @Override
  public String getConfigurationUrl() {
    YarnConfiguration conf = new YarnConfiguration();
    String httpPolicy = conf.get(TaskFactory.YARN_HTTP_POLICY);
    if (httpPolicy != null && 
httpPolicy.equals(TaskFactory.YARN_HTTP_POLICY_HTTPS_ONLY)) {
      String address = 
conf.get(TaskFactory.YARN_RESOURCEMANAGER_WEBAPP_HTTPS_ADDRESS);
      if (address == null || address.isEmpty()) {
        address = conf.get(TaskFactory.YARN_RESOURCEMANAGER_HOSTNAME) + ":8090";
      }
      return "https://"; + address + "/conf";
    } else {
      String address = 
conf.get(TaskFactory.YARN_RESOURCEMANAGER_WEBAPP_ADDRESS);
      if (address == null || address.isEmpty()) {
        address = conf.get(TaskFactory.YARN_RESOURCEMANAGER_HOSTNAME) + ":8088";
      }
      return "http://"; + address + "/conf";
    }
  }


I don't believe there should be any code in Myriad that uses preset/hardcoded 
ports for Yarn.  That needs to come from configs, not from the Myriad code.   

> RM Ports are Hardcoded in NMExecutorCLGenImpl.java
> --------------------------------------------------
>
>                 Key: MYRIAD-184
>                 URL: https://issues.apache.org/jira/browse/MYRIAD-184
>             Project: Myriad
>          Issue Type: Bug
>          Components: Executor
>    Affects Versions: Myriad 0.1.0
>            Reporter: John Omernik
>              Labels: easyfix, newbie
>
> In NMExecutorCLGenImpl.java, the ports for Resource Manager are derived via 
> the http.policy config setting. Instead, the ports should be using a 
> different variable that actually corresponds to running port. The ports that 
> are hard coded are the default ports for the RM for HTTP and HTTPS (8088, and 
> 8090) but if a user changed the port, the config download would fail.   Thus 
> finding a better variable here would help make it so operators are not 
> limited to the default ports in their environments. 
> (Hard Coding in function public String getConfigurationUrl())
> https://github.com/apache/incubator-myriad/blob/df7d05c8639b371b94a1e94406e2f2446d10eaaf/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)