[
https://issues.apache.org/jira/browse/MYRIAD-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287094#comment-15287094
]
John Yost commented on MYRIAD-198:
----------------------------------
Updated per feedback from Darin, returning empty Map objects and updated
calling code accordingly.
> Remove optionals when sane defaults are available
> -------------------------------------------------
>
> Key: MYRIAD-198
> URL: https://issues.apache.org/jira/browse/MYRIAD-198
> Project: Myriad
> Issue Type: Bug
> Components: Executor, Scheduler
> Affects Versions: Myriad 0.2.0
> Reporter: DarinJ
> Priority: Minor
> Labels: easyfix, newbie
>
> Currently we overuse Optionals in the config and then use an or method in
> various factories later. In many cases having the configuration return a
> default when the parameter was specified would create cleaner code. For
> instance:
> {quote}
> Optional<Boolean> getCgroups() {
> Optional.fromNullable(cgroups);
> }
> {quote}
> vs
> {quote}
> Boolean getCgroups() {
> return cgroups != null ? cgroups : false;
> }
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
