+1 (binding)

Steps for release review:

1. Download the RC1 release:
$ wget -e robots=off -r -nH --cut-dirs=5 --no-parent -R "index.html*"
$ cd myriad-0.4.0-incubating-rc1/
$ wget https://dist.apache.org/repos/dist/dev/incubator/myriad/KEYS

2. Signatures checking:
$ gpg --import KEYS
$ gpg --verify myriad-0.4.0-incubating-rc1.tar.gz.asc

3. Checksum checking:
$ gpg --print-md SHA512 myriad-0.4.0-incubating-rc1.tar.gz | diff -

4. Disclaimer and Notice files:
Verify the incubator disclaimer is in a separate file called DISCLAIMER,
residing inside the top-level distribution folder, along with the LICENSE and
NOTICE files.

5. All source files have license headers, where appropriate:
$ wget 
$ cat rat-excludes

$ java -jar apache-rat-0.13.jar -E rat-excludes -d
myriad-0.4.0-incubating-rc1 > report

6. Release consists of source code only, no binaries:
$ find . -name *.jar

7. Build is successful, including automated tests:
$ gradle wrapper --gradle-version 5.5
$ ./gradlew build
$ find . -name *.jar

Review summary

Checked PGP signatures
Checked Checksums
LICENSE checked
NOTICE checked
RAT Check passes
Source code only checked
Build and unitary tests checked
Functional testing checked with Apache Mesos 1.8.0 with success.

Some minor issue:

$ find . -name *.jar | grep 0.3.0

The binary has the wrong version number (right now is 0.4.0), this is
something to fix in the
next version.

Javi Roman

Twitter: @javiromanrh
GitHub: github.com/javiroman
Linkedin: es.linkedin.com/in/javiroman
Big Data Blog: dataintensive.info
Apache Id: javiroman

On Wed, Aug 14, 2019 at 2:20 PM Oscar Fernandez <oscarf...@apache.org> wrote:
> Hi All,
> I would like to start the voting process of a new release of Apache Myriad
> (Incubator).
> I have created a source tar ball for Apache Myriad 0.4.0-incubating,
> release candidate 1.
> 1. Release notes:
> https://github.com/apache/incubator-myriad/blob/master/CHANGELOG.md
> 2. The commit to be voted upon is tagged with "myriad-0.4.0-incubating-rc1"
> and is available here:
> https://gitbox.apache.org/repos/asf?p=incubator-myriad.git;a=commit;h=019fba2be3e310302cd60a25d7d71f1310c9d5a5
> 3. The artifacts to be voted upon are located below. Please note that this
> is a Source Release:
> https://dist.apache.org/repos/dist/dev/incubator/myriad/myriad-0.4.0-incubating-rc1/
> 4. Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/oscarfmdc.asc
> 5. Please note that the release tar ball does not include the gradlew
> script to build. You need to generate one in order to build:
> $ gradle wrapper --gradle-version 5.5
> $ ./gradlew build
> Please try out the release candidate and vote. The vote is open for a
> minimum of 72 hours or until the necessary number of votes (3 binding +1s)
> is reached.
> Note: We have a lot of warnings in the build related with deprecated
> features in Gradle 6.0, Findbugs, and PDM plugins. This will fixed in the
> next versions.
> If/when this vote succeeds, I will call for a vote with IPMC seeking
> permission to release RC1 as Apache Myriad 0.4.0 (incubating).
> [ ] +1 Release this package as Apache Myriad 0.4.0-incubating
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
> Many thanks!!!
> Note: We need  at least 3 +1 binding votes (included PPMCs and Mentors).

Reply via email to