wonook commented on a change in pull request #4: [NEMO-28] Javadoc and Travis
URL: https://github.com/apache/incubator-nemo/pull/4#discussion_r172517551
 
 

 ##########
 File path: common/src/main/java/edu/snu/nemo/common/test/ArgBuilder.java
 ##########
 @@ -19,12 +19,14 @@
 import java.util.Arrays;
 import java.util.List;
 import java.util.StringJoiner;
-import java.util.stream.Collectors;
+import java.util.stream.Stream;
 
 /**
  * Argument builder.
  */
 public final class ArgBuilder {
+  private static final List<List<String>> DEFAULT_ARGS = 
Arrays.asList(Arrays.asList("-executor_json",
 
 Review comment:
   It's quite difficult, since Tang appears after this step, and it created 
duplication of code, which will later require refactoring in some other way. 
I've cleaned up the code a bit to make it look more neat.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to