johnyangk commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup 
pipelining
URL: https://github.com/apache/incubator-nemo/pull/2#discussion_r172703316
 
 

 ##########
 File path: common/src/main/java/edu/snu/nemo/common/ir/Pipe.java
 ##########
 @@ -23,7 +23,7 @@
  * runtime-specific distributed data movement and storage mechanisms.
  * @param <O> output type.
  */
-public interface OutputCollector<O> extends Serializable {
+public interface Pipe<O> extends Serializable {
 
 Review comment:
   IMHO, `OutputCollector` is a better name.
   - `OutputCollector` explicitly tells you that it is used to collect outputs
   - People may confuse this `Pipe` class with the `Pipe` execution property.
   
   Storm/Flink also use `OutputCollector` as the name of the class for emitting 
outputs.
   - Storm: 
https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/task/OutputCollector.java
   - Flink: 
https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/operators/shipping/OutputCollector.java

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to