seojangho commented on a change in pull request #1: [NEMO-26] Implement
SourceLocationAwareSchedulingPolicy
URL: https://github.com/apache/incubator-nemo/pull/1#discussion_r172755632
##########
File path:
runtime/master/src/main/java/edu/snu/nemo/runtime/master/RuntimeMaster.java
##########
@@ -274,16 +271,12 @@ private void handleControlMessage(final
ControlMessage.Message message) {
convertFailureCause(taskGroupStateChangedMsg.getFailureCause()));
break;
case ExecutorFailed:
+ // Executor failed due to user code.
final ControlMessage.ExecutorFailedMsg executorFailedMsg =
message.getExecutorFailedMsg();
final String failedExecutorId = executorFailedMsg.getExecutorId();
final Exception exception =
SerializationUtils.deserialize(executorFailedMsg.getException().toByteArray());
LOG.error(failedExecutorId + " failed, Stack Trace: ", exception);
- containerManager.onExecutorRemoved(failedExecutorId);
throw new RuntimeException(exception);
Review comment:
Friendly cc to @johnyangk :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
