seojangho commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup
pipelining
URL: https://github.com/apache/incubator-nemo/pull/2#discussion_r172762043
##########
File path:
common/src/main/java/edu/snu/nemo/common/ir/vertex/transform/Transform.java
##########
@@ -32,16 +30,15 @@
/**
* Prepare the transform.
* @param context of the transform.
- * @param outputCollector that collects outputs.
+ * @param pipe that collects outputs.
*/
- void prepare(Context context, OutputCollector<O> outputCollector);
+ void prepare(Context context, Pipe<O> pipe);
/**
* On data received.
- * @param elements data received.
- * @param srcVertexId sender of the data.
+ * @param element data received.
*/
- void onData(Iterator<I> elements, String srcVertexId);
+ void onData(Object element);
Review comment:
We declared input type as `<I>`.
```java
void onData(I element);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
