sanha commented on a change in pull request #1: [NEMO-26] Implement
SourceLocationAwareSchedulingPolicy
URL: https://github.com/apache/incubator-nemo/pull/1#discussion_r173065772
##########
File path:
runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/SchedulingPolicy.java
##########
@@ -17,15 +17,20 @@
import edu.snu.nemo.runtime.common.plan.physical.ScheduledTaskGroup;
import edu.snu.nemo.runtime.master.JobStateManager;
+import edu.snu.nemo.runtime.master.resource.ExecutorRepresenter;
import org.apache.reef.annotations.audience.DriverSide;
import org.apache.reef.tang.annotations.DefaultImplementation;
+import javax.annotation.concurrent.ThreadSafe;
import java.util.Set;
/**
+ * (WARNING) Implementations of this interface must be thread-safe.
+ *
* Defines the policy by which {@link BatchSingleJobScheduler} assigns task
groups to executors.
*/
@DriverSide
+@ThreadSafe
@DefaultImplementation(RoundRobinSchedulingPolicy.class)
Review comment:
Let's change the default policy to the source location aware policy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
